fix(output): preserve tail lines to prevent CI summary loss (#1035)#1221
Open
ousamabenyounes wants to merge 1 commit intortk-ai:developfrom
Open
fix(output): preserve tail lines to prevent CI summary loss (#1035)#1221ousamabenyounes wants to merge 1 commit intortk-ai:developfrom
ousamabenyounes wants to merge 1 commit intortk-ai:developfrom
Conversation
pszymkowiak
added
bug
Collaborator
📊 Automated PR Analysis
SummaryFixes CI summary loss by updating both Review Checklist
Linked issues: #1035 Analyzed automatically by wshm · This is an automated analysis, not a human review. |
) make.toml used max_lines=50 which truncated from the head, discarding tail lines where pytest/vitest summaries always appear. truncate_output() had the same problem for parser passthrough. Both now keep head + last 20 lines with an omission marker in between so CI results are always visible. Generated by Claude Code Vibe coded by ousamabenyounes Co-Authored-By: Claude <noreply@anthropic.com>
ousamabenyounes
force-pushed
the
fix/issue-1035
branch
from
a5e7cc4 to
956a3e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1035
make.tomlhadmax_lines = 50which kept only the first 50 lines of filtered output, discarding the tail where CI tools (pytest, vitest) always print their pass/fail summariestruncate_output()insrc/parser/mod.rskept only the head chars in passthrough mode, causing the same summary loss when the vitest JSON parser falls through to Tier 3Test plan
cargo fmt --all && cargo clippy --all-targets && cargo testtest_truncate_output_preserves_tail— 101-line CI output, verifies "251 passed, 18 skipped" survives truncationtest_truncate_output_tail_shows_last_20_lines— 50-line output, all 20 summary lines appear in tail"preserves tail for long composite output"— 51 filtered make lines, head=20 + omit(1) + tail=30Files changed
src/filters/make.tomlmax_lines = 50withhead_lines = 20, tail_lines = 30; add tail-preservation test casesrc/parser/mod.rstruncate_output()to show head + tail with omission marker; add 2 new testsGenerated by Claude Code
Vibe coded by ousamabenyounes